This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Aligns MutableDictionaryArray's with MutablePrimitiveArrays with TryPush #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes the ability to build an invalid map. try_push_valid relied on the user pushing a value to the values stack.
jorgecarleitao
approved these changes
May 6, 2022
src/array/dictionary/mutable.rs
Outdated
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
Could we move this to tests/it/array? we have all our tests there so that the compilation of the crate is not triggered when only the tests change.
There was a problem hiding this comment.
I can do that. It will need two new pub functions on MutableDictionaryArray, which are required to test TryPush?
/// Returns the dictionary map
pub fn map(&self) -> &HashedMap<u64, K> {
&self.map
}
/// Returns the dictionary keys
pub fn keys(&self) -> &MutablePrimitiveArray<K> {
&self.keys
}I'll also add an explicit return for the doctest to satisfy Miri.
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
==========================================
- Coverage 71.51% 71.42% -0.10%
==========================================
Files 357 357
Lines 19696 19739 +43
==========================================
+ Hits 14086 14098 +12
- Misses 5610 5641 +31
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes the ability to build an invalid map when pushing individual values. try_push_valid relied on the user pushing a value to the values stack.
Could have contributed to an invalid file was generated and bug found in #976.